Skip to content

Solution for User role issue with customer group #16499#17361

Closed
ghost wants to merge 3 commits into2.2-developfrom
unknown repository
Closed

Solution for User role issue with customer group #16499#17361
ghost wants to merge 3 commits into2.2-developfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Aug 4, 2018

Solution for User role issue with customer group #16499

Description

Now the “customer group” menu is displayed under "customers" menu on the admin side and store menu is invisible for new user. issue was is ACL file.
In ACL file 'Customer group should be in 'Magento_Customer::customer' instead of 'Magento_Backend::stores_other_settings'.

Fixed Issues (if relevant)

  1. User role issue with customer group #16499: User role issue with customer group User role issue with customer group #16499

Manual testing scenarios

1 .System > Permission > User Roles.
2. Create a user role with 'customer group' permission which is specified in issue steps.
3. Login with new user credential. now only customer menu is enabled and store menu is not visible for new user.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Aug 4, 2018

Hi @emiprotech. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

This file is changed for other issue
d0b1a6e 
This file is changed for other issue's solution but by mistake it is displaying in this pull request.
@sidolov
Copy link
Copy Markdown
Contributor

sidolov commented Aug 5, 2018

Hi @emiprotech , please, resolve merge conflict

@ghost
Copy link
Copy Markdown
Author

ghost commented Aug 6, 2018

Hi sidolov,
app/code/Magento/Catalog/Block/Product/ImageBuilder.php
This is unnecessary file for this pull request so please ignore this file from this pull request.

app/code/Magento/Customer/etc/acl.xml
In above file there is a solution for User role issue with customer group #16499

@ihor-sviziev
Copy link
Copy Markdown
Contributor

ihor-sviziev commented Aug 8, 2018

Hi @emiprotech,
Unfortunately we can't accept PR with conflict, also it's really hard to guess what changes you wanted propose.
Please fix conflict with 2.2-develop branch and we'll try to process your PR

@ghost
Copy link
Copy Markdown
Author

ghost commented Aug 11, 2018

I have created new pull request and I am closing this PR.
New PR is #17515.

@ghost ghost closed this Aug 11, 2018
@ghost ghost deleted the solution-16499 branch August 11, 2018 04:10
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Component: Catalog Component: Customer Progress: needs update Release Line: 2.2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@magento-engcom-team @sidolov @ihor-sviziev